ENG-1405 Fix restore testing plan name: replace hyphens with underscores and remove tautological suffix - #48
Merged
Merged
Conversation
terado
force-pushed
the
bug/dh-tautology
branch
from
August 10, 2026 14:16
5052ff3 to
6136b9b
Compare
…_testing_plan suffix
terado
force-pushed
the
bug/dh-tautology
branch
from
August 10, 2026 14:27
6136b9b to
5832f49
Compare
terado
approved these changes
Aug 10, 2026
susana-zhou1
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the
restore_testing_plan_namein the source module to comply with the AWS Backup API constraint that only allows alphanumeric characters and underscores. Replaces hyphens inlocal.resource_name_prefixwith underscores viareplace(), and removes the redundant_backup_restore_testing_plansuffix that consumed 28 of the 50-character limit without adding value.Context
The AWS
RestoreTestingPlanNamefield must consist of only alphanumeric characters and underscores (max 50 chars). The previous implementation either appended a tautological suffix (_backup_restore_testing_plan) or fell back to a hardcoded name, and did not handle hyphens that naturally appear inresource_name_prefix(e.g. from region names likeeu-west-2). This caused failures for environments with longer prefixes (e.g. mesh) where the 50-char limit was exceeded.Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.